Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsonnet: fix ruler-querier autoscaling target utilization #5682

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

pracucci
Copy link
Collaborator

@pracucci pracucci commented Aug 4, 2023

What this PR does

As spotted by @jhesketh here (thanks!) I did two mistakes in #5679, which I'm fixing in this PR:

  • ruler-querier has no memory-based autoscaling
  • autoscaling_ruler_querier_cpu_target_utilization was not applied

Which issue(s) this PR fixes or relates to

N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci marked this pull request as ready for review August 4, 2023 14:57
@pracucci pracucci requested a review from a team as a code owner August 4, 2023 14:57
Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@pracucci pracucci merged commit ae523c7 into main Aug 4, 2023
28 checks passed
@pracucci pracucci deleted the fix-autoscaling branch August 4, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants