Distributor: add config flag to control error code when rate limit reached #5752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ying-jeanne
force-pushed
the
addflag
branch
2 times, most recently
from
30a5194
to
0887a68
Compare
pstibrany
reviewed
Aug 15, 2023
pstibrany
reviewed
Aug 15, 2023
ying-jeanne
force-pushed
the
addflag
branch
2 times, most recently
from
39e25c8
to
7a17b76
Compare
pstibrany
reviewed
Aug 17, 2023
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
approved these changes
Aug 17, 2023
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
approved these changes
Aug 17, 2023
pstibrany
added a commit
that referenced
this pull request
Aug 30, 2023
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
1 task
pstibrany
added a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
added a commit
that referenced
this pull request
Sep 7, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributor: add config flag to control error code when rate limit reached
What this PR does
Introducing a dedicated flag for this specific cell/tenant. When activated, it ensures a 503 response instead of a 429 under specific conditions. This facilitates client retries, minimizing data loss during pushes.
Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]