Improve observability of enqueuing requests to query-scheduler #5818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror reported when the scheduler reports an error.
charleskorn
commented
Aug 23, 2023
| @@ -222,9 +226,12 @@ func (f *Frontend) RoundTripGRPC(ctx context.Context, req *httpgrpc.HTTPRequest) | |||
| retries := f.cfg.WorkerConcurrency + 1 // To make sure we hit at least two different schedulers. | |||
|
|
|||
| enqueueAgain: | |||
| level.Debug(spanLogger).Log("msg", "enqueuing request") | |||
There was a problem hiding this comment.
Note to reviewers: I've deliberately added this request started event and the "request succeeded" event below despite adding the span in enqueueRequest, as it's possible there's a delay between a request being added to f.requestsCh and it being picked up and enqueued by a worker.
pstibrany
approved these changes
Aug 23, 2023
| req.response <- &frontendv2pb.QueryResultRequest{ | ||
| HttpResponse: &httpgrpc.HTTPResponse{ | ||
| Code: http.StatusInternalServerError, | ||
| Body: []byte(resp.Error), |
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR improves the observability of query-frontend interactions with query-schedulers.
In particular:
nil, is now logged when the scheduler returns an error (here)Example trace looks like this now:
Note to reviewers: I'd suggest reviewing each commit separately.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]