Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingester: active_native_histograms_postings #7982

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

krajorama
Copy link
Contributor

What this PR does

Be able to return active native histograms postings so that we can list them on an API later.

Mostly copy paste from active_postings.

Which issue(s) this PR fixes or relates to

Related to: #7981

Checklist

  • Tests updated.
  • N/A Documentation added.
  • N/A CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • N/A about-versioning.md updated with experimental features.

Be able to return active native histograms postings so that
we can list them on an API later.

Mostly copy paste from active_postings.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama requested a review from a team as a code owner April 26, 2024 10:14
Copy link
Contributor

@flxbk flxbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
@krajorama krajorama merged commit 36b35d1 into main Apr 26, 2024
29 checks passed
@krajorama krajorama deleted the krajo/native-histograms-cardinality-api branch April 26, 2024 11:45
krajorama added a commit that referenced this pull request Apr 26, 2024
* ingester: active_native_histograms_postings

Be able to return active native histograms postings so that
we can list them on an API later.

Mostly copy paste from active_postings.

Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants