Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mixins): disk space utilization panels #8212

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented May 29, 2024

What this PR does

This PR fixes the disk space utilization panels which are not working when running with a kube-state-metrics version >= 2.10 because of missing kube_persistentvolumeclaims_labels metrics

Which issue(s) this PR fixes or relates to

Fixes #7515

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@QuentinBisson QuentinBisson force-pushed the fix-mixins-disk-space-utilization-panel branch from 9435d35 to c843ae6 Compare May 29, 2024 14:15
@QuentinBisson
Copy link
Contributor Author

Hey @ying-jeanne thanks for the fast feedback. That is correct but the name label that should be on the PVC is actually gone when I deploy the dashboard on my side :)

@ying-jeanne
Copy link
Contributor

Hi thanks for the contribution, going through the changelog of kube-state-metrics, the label and annotation metrics are not deprecated but deactivated by default, during we are reviewing the PR, you can use --metric-labels-allowlist to explicitly export the related metrics.

@ying-jeanne
Copy link
Contributor

Hey @ying-jeanne thanks for the fast feedback. That is correct but the name label that should be on the PVC is actually gone when I deploy the dashboard on my side :)

Just saw you attached conversation with Dimitar, tested some of the queries, they work as expected. Since he has already context on it, I would leave him for the review.

@QuentinBisson
Copy link
Contributor Author

@dimitarvdimitrov do you think you could check this PR?

Copy link
Contributor

@dimitarvdimitrov dimitarvdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Thank you very much 🙌

@dimitarvdimitrov dimitarvdimitrov merged commit fc7ef9f into grafana:main Jun 5, 2024
31 checks passed
narqo pushed a commit to narqo/grafana-mimir that referenced this pull request Jun 6, 2024
* fix(mixins): disk space utilization panels

* add changelog entry

Signed-off-by: QuentinBisson <quentin@giantswarm.io>

---------

Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mimir mixin Disk space utilization panels broken for mimir helm chart
3 participants