Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distributor: Drop experimental flag for non-direct OTLP translation #9647

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Oct 16, 2024

What this PR does

Drop experimental distributor flag -distributor.direct-otlp-translation-enabled (default: true), since direct OTLP translation has now been in production for ~5 months and has proven itself problem free. Less code 🎉

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@aknuds1 aknuds1 force-pushed the arve/drop-old-translation branch 2 times, most recently from b91c509 to 9ca1798 Compare October 16, 2024 14:53
@aknuds1 aknuds1 marked this pull request as ready for review October 16, 2024 14:53
@aknuds1 aknuds1 requested review from tacole02 and a team as code owners October 16, 2024 14:53
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 force-pushed the arve/drop-old-translation branch from 9ca1798 to 6f91fcc Compare October 16, 2024 16:13
@aknuds1 aknuds1 changed the title distributor: Drop flag for non-direct OTLP translation distributor: Drop experimental flag for non-direct OTLP translation Oct 16, 2024
Copy link
Contributor

@seizethedave seizethedave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM%c 😺

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: David Grant <david.grant@grafana.com>
@aknuds1 aknuds1 merged commit 7fd21a9 into main Oct 16, 2024
29 checks passed
@aknuds1 aknuds1 deleted the arve/drop-old-translation branch October 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants