query-frontend: Do not break scheduler connection on malformed queries #9786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
francoposa
approved these changes
Oct 31, 2024
4 tasks
This was referenced Nov 1, 2024
This was referenced Nov 1, 2024
codesome
added a commit
that referenced
this pull request
Nov 1, 2024
#9786) (#9790) * query-frontend: Do not break scheduler connection on malformed queries Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Updated tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> (cherry picked from commit 587d234) Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
codesome
added a commit
that referenced
this pull request
Nov 1, 2024
#9786) (#9788) * query-frontend: Do not break scheduler connection on malformed queries Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Updated tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> (cherry picked from commit 587d234) Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
codesome
added a commit
that referenced
this pull request
Nov 1, 2024
#9786) (#9792) * query-frontend: Do not break scheduler connection on malformed queries Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Updated tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> (cherry picked from commit 587d234) Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
codesome
added a commit
that referenced
this pull request
Nov 1, 2024
#9786) (#9789) * query-frontend: Do not break scheduler connection on malformed queries Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Updated tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> (cherry picked from commit 587d234) Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>
This was referenced Nov 5, 2024
narqo
added a commit
that referenced
this pull request
Nov 6, 2024
…alformed queries (#9833) * query-frontend: Do not break scheduler connection on malformed queries (#9786) * query-frontend: Do not break scheduler connection on malformed queries Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Updated tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> (cherry picked from commit 587d234) * update changelog Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> --------- Signed-off-by: Vladimir Varankin <vladimir.varankin@grafana.com> Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: Vladimir Varankin <vladimir.varankin@grafana.com>
deniszh
pushed a commit
to deniszh/mimir
that referenced
this pull request
Nov 14, 2024
grafana#9786) * query-frontend: Do not break scheduler connection on malformed queries Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Updated tests Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> --------- Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Instead of breaking the scheduler connection for malformed queries and eventually sending 500, instead send 400 and do not break the scheduler connection.
This is another version of what #9782 was trying to do.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.