Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go toolchain version to use the 1.N.P syntax #4877

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

joeyorlando
Copy link
Contributor

What this PR does

Fixes this CodeQL warning:
Screenshot 2024-08-20 at 15 10 42

Go docs on 1.N.P syntax versioning

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@joeyorlando joeyorlando added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Aug 20, 2024
@joeyorlando joeyorlando requested a review from a team as a code owner August 20, 2024 19:11
@joeyorlando joeyorlando merged commit fefa9d1 into dev Aug 23, 2024
24 checks passed
@joeyorlando joeyorlando deleted the jorlando/update-go-toolchain-version branch August 23, 2024 15:49
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does

Fixes [this CodeQL
warning](https://github.com/grafana/oncall/security/code-scanning/tools/CodeQL/status/configurations/automatic/69f48dd4390b44ab31e994b324fcb2b55dc7b51c7542feb4e14e5a6a5b7f869b):
<img width="1246" alt="Screenshot 2024-08-20 at 15 10 42"
src="https://github.com/user-attachments/assets/7e643a71-4c36-47dc-9dff-cb666419286f">


[Go docs](https://go.dev/doc/toolchain#version) on 1.N.P syntax
versioning

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants