Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip user notification if alert group is already resolved #5145

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Skip user notification if alert group is already resolved #5145

merged 1 commit into from
Oct 9, 2024

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Oct 9, 2024

Sometimes a task is queued and scheduled for later (or for a retry too), but the alert group is resolved by then. Skip notification in that case.

@matiasb matiasb added pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes labels Oct 9, 2024
@matiasb matiasb marked this pull request as ready for review October 9, 2024 17:54
@matiasb matiasb requested a review from a team as a code owner October 9, 2024 17:54
@matiasb matiasb added this pull request to the merge queue Oct 9, 2024
Merged via the queue into dev with commit b79c5d0 Oct 9, 2024
29 checks passed
@matiasb matiasb deleted the matiasb/skip-notification-if-resolved branch October 9, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mderynck mderynck mderynck approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @mderynck