Change thresholds for row group and block target size

grafana · Feb 10, 2023 · 88d6b22 · 88d6b22
1 parent 592a139
commit 88d6b22
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/phlaredb/deduplicating_slice.go b/pkg/phlaredb/deduplicating_slice.go
@@ -24,8 +24,8 @@ var int64SlicePool = &sync.Pool{
 
 var defaultParquetConfig = &ParquetConfig{
 	MaxBufferRowCount: 100_000,
-	MaxRowGroupBytes:  128 * 1024 * 1024,
-	MaxBlockBytes:     10 * 128 * 1024 * 1024,
+	MaxRowGroupBytes:  10 * 128 * 1024 * 1024,
+	MaxBlockBytes:     10 * 10 * 128 * 1024 * 1024,
 }
 
 type deduplicatingSlice[M Models, K comparable, H Helper[M, K], P schemav1.Persister[M]] struct {

diff --git a/pkg/phlaredb/phlaredb.go b/pkg/phlaredb/phlaredb.go
@@ -60,7 +60,7 @@ type ParquetConfig struct {
 func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
 	f.StringVar(&cfg.DataPath, "phlaredb.data-path", "./data", "Directory used for local storage.")
 	f.DurationVar(&cfg.MaxBlockDuration, "phlaredb.max-block-duration", 3*time.Hour, "Upper limit to the duration of a Phlare block.")
-	f.Uint64Var(&cfg.RowGroupTargetSize, "phlaredb.row-group-target-size", 100*1024*1024, "How big should a single row group be")
+	f.Uint64Var(&cfg.RowGroupTargetSize, "phlaredb.row-group-target-size", 10*128*1024*1024, "How big should a single row group be uncompressed") // This should roughly be 128MiB compressed
 }
 
 type fileSystem interface {