This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
feat(agent/sd): add support HTTP service discovery #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
approved these changes
Jan 2, 2023
There was a problem hiding this comment.
LGTM
Merging this but ultimately we're moving toward Grafana Agent see grafana/agent#2552
Thanks @cyriltovena , I look forward to seeing the implementation and release of the Phlare Agent function on the Grafana Agent as soon as possible, and I will continue to pay attention. HTTP is a common service discovery mechanism, and it can be used on the lightweight Phlare Agent together with Kubenetes and static SD. |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…nt-http-sd feat(agent/sd): add support HTTP service discovery
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add agent config to support HTTP service discovery, use Prometheus HTTP SD config.