This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Add an API go module for external usage. #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
simonswine
approved these changes
Jan 9, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Add an API go module for external usage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new go module ( API ) that can be imported by other projects. It takes advantage of go workspace.
I had to remove
go mod verifywhich is not yet compatible with workspace.I've also taken the opportunity to reversion v1 to v1alpha1.
Once tagged
api/v0.1.1the module should be available.see https://go.dev/doc/modules/managing-source
This is a breaking change as path for each method have changed.