This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Add query-frontend, query-scheduler and querier worker. #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Feb 3, 2023
simonswine
approved these changes
Feb 6, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
…re#496) * Introducing frontend and scheduler * revert prometheus change * Hook up the frontend with query-scheduler and querier * Ensure missing tenant id is propagated correctly. * Refactoring querier transport/handler. * Update helm * Update the documentation to reflect new changes * Removes todos * make go/mod * make docs/validate * make lint * make lint * make helm/check * fixes race * fixes timeout issues with scheduler-querier
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enable the same read path as Mimir and Loki.
The query-frontend and query-scheduler are now new component of Phlare that ensure fair scheduling and queries acceleration in the future.
When using the All target (single binary) they are activated automatically. In distributed mode they are not mandatory but active by default.
The configuration rely on ring based service discovery using the mandatory memberlist configuration.
The code is mostly a copy/pasted from Mimir, but adapted to work with connect-go. see connectgrpc package.
I'm planning to add runtime configs and tenant configs as a follow up.