Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Support set test mode for flags test #542

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

Rustin170506
Copy link
Contributor

cmd/phlare/main.go Outdated Show resolved Hide resolved
cmd/phlare/main.go Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self check

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this case 👍

LGTM

@simonswine simonswine merged commit 0c86a95 into grafana:main Feb 27, 2023
@Rustin170506 Rustin170506 deleted the rustin-patch-test-mode branch February 27, 2023 09:17
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
* Support set test mode for flags test

* Move it to dynamic.go

* Fix test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants