refactor: cmd/phlare/main.go

cmd/phlare/main.go

@@ -43,29 +43,29 @@ func (mf *mainFlags) RegisterFlags(fs *flag.FlagSet) {
 	fs.BoolVar(&mf.PrintHelp, "help", false, "Print basic help.")
 	fs.BoolVar(&mf.PrintHelpAll, "help-all", false, "Print help, also including advanced and experimental parameters.")
 }
+func errorHandler() {
+	testMode := cfg.GetTestMode()
+	if !testMode {
+		os.Exit(1)
+	}
 
+}
 func main() {
 	var (
 		flags mainFlags
 	)
 
-	testMode := cfg.GetTestMode()
-
 	if err := cfg.DynamicUnmarshal(&flags, os.Args[1:], flag.CommandLine); err != nil {
 		fmt.Fprintf(os.Stderr, "failed parsing config: %v\n", err)
-		if testMode {
-			return
-		}
-		os.Exit(1)
+		errorHandler()
+		return
 	}
 
 	f, err := phlare.New(flags.Config)
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "failed creating phlare: %v\n", err)
-		if testMode {
-			return
-		}
-		os.Exit(1)
+		errorHandler()
+		return
 	}
 
 	if flags.PrintVersion {
@@ -97,10 +97,8 @@ func main() {
 		flag.CommandLine.SetOutput(os.Stdout)
 		if err := usage.Usage(flags.PrintHelpAll, &flags); err != nil {
 			fmt.Fprintf(os.Stderr, "error printing usage: %s\n", err)
-			if testMode {
-				return
-			}
-			os.Exit(1)
+			errorHandler()
+			return
 		}
 
 		return
@@ -109,9 +107,7 @@ func main() {
 	err = f.Run()
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "failed running phlare: %v\n", err)
-		if testMode {
-			return
-		}
-		os.Exit(1)
+		errorHandler()
+		return
 	}
 }