Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Refactor metrics in PhlareDB #574

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Refactor metrics in PhlareDB #574

merged 2 commits into from
Mar 10, 2023

Conversation

cyriltovena
Copy link
Collaborator

Not only this is easier to manage, but this is also more resilient.

@cyriltovena cyriltovena enabled auto-merge (squash) March 9, 2023 18:06
@cyriltovena cyriltovena requested a review from simonswine March 9, 2023 20:24
Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning that up!

Tried it locally works well 👍

LGTM

Comment on lines +16 to +19
already, ok := err.(prometheus.AlreadyRegisteredError)
if ok {
return already.ExistingCollector.(T)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I wasn't aware that you have that custom error type

@cyriltovena cyriltovena merged commit 43d7c3b into main Mar 10, 2023
@cyriltovena cyriltovena deleted the refactor-metrics branch March 10, 2023 11:22
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
* Refactor metrics in PhlareDB

* Refactor metrics in PhlareDB
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants