This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it's more explicit and easier when pyroscope-oss dep is removed
simonswine
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have given that a try locally and all seems to have worked as described by you.
Thanks for the hardwork, great to see things coming together 🙂
Co-authored-by: Christian Simon <simon@swine.de>
@petethepig Maybe we should use |
Can I ask how it relates to the original UI of the phare and the UI of the pyroscope? In what way will they be combined or coexist in the future? Thanks! |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
feat(frontend): add single view page
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple UI page similar to Pyroscope's "Single View".
Screen.Recording.2023-04-04.at.17.09.31.mov
Breakdown:
Tried to use as much from
pyroscope-oss
as possible. This is so that we have a single "source of truth". As requirements come up we will definitely diverge from this approach.It works by importing the
pyroscope-oss
git repo as a npm dependency. Then we refer to the files using typescript's path/alias functionality.Certain files are overriden using the same path/alias functionality. One problem is that these overrides need to be set explicitly in both
tsconfig.json
andwebpack.common.js
. I tried to unify them usingtsconfig-paths-webpack-plugin
, but it didn't work when you have 2 definitions for the same file (for example a catch all then a more specific rule). It's okay for now, since it's just an intermediate step until we reimplement the entire functionality here, and therefore these overrides won't be necessary anymore.To query application names we use
/pyroscope/label-values?label=__name__
which doesn't translate very well to phlare's storage/query system since there's no concept of "Applications". Need some guidance on how to approach this.Tags don't work.
It doesn't infer units/spyName correctly, for units it's technically possible, just need to map based on the "app name". For example,
process_cpu:samples:count:cpu:nanoseconds
issamples
,memory:alloc_space:bytes::
isbytes
etc.