This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Apr 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this already goes in a good way.
I think we should at least support matchers (as they are supported by our index as present (as opposed to the exact timestamps supplied by from/to)
Here is a curl example of this:
curl -sL -d '{"matchers": ["{__profile_type__=\"goroutine:goroutine:count:goroutine:count\"}"]}' -X POST -H "content-type: application/json" https://play-phlare.grafana.org/querier.v1.QuerierService/Series
{"labelsSet":[{"labels":[{"name":"__name__", "value":"goroutine"}, {"name":"__period_type__", "value":"goroutine"}, {"name":"__period_unit__", "value":"count"}, {"name":"__profile_type__", "value":"goroutine:goroutine:count:goroutine:count"}, {"name":"__type__", "value":"goroutine"}, {"name":"__unit__", "value":"count"}, {"name":"app_kubernetes_io_component", "value":"all"}, {"name":"app_kubernetes_io_instance", "value":"phlare"}, {"name":"app_kubernetes_io_name", "value":"phlare"}, {"name":"container", "value":"phlare"}, {"name":"controller_revision_hash", "value":"phlare-58775689d6"}, {"name":"instance", "value":"10.145.176.117:4100"}, {"name":"job", "value":"kubernetes-pods-name"}, {"name":"name", "value":"phlare"}, {"name":"namespace", "value":"profiles-prod-play"}, {"name":"pod", "value":"phlare-0"}, {"name":"statefulset_kubernetes_io_pod_name", "value":"phlare-0"}]}]
|
simonswine
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This works well for the single binary mode. But when I try the micro-services mode, it misses the pyroscope endpoints. (I will look into a separate PR).
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
feat: make tags work in the ui
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-04-11.at.10.46.57.mov
Adds supports to the labels/tags selector in the UI. It uses the
querier.v1.QuerierService/Series
API as suggested by @simonswineprofileTypeId
. For example, it doesn't show dynamic tags for memory, only CPU.