This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Support selectors for LabelValues/LabelNames calls #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are now using a common type between ingester/querier
This will allow a more effiecent auto-suggest, esp with high cardinality tenants.
simonswine
changed the title
simonswine
changed the title
simonswine
added a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Refactor label name/values request/responses They are now using a common type between ingester/querier * Supporter matchers on LabelNames/LabelValues This will allow a more effiecent auto-suggest, esp with high cardinality tenants.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support selectors on the
LabelNames/Valuescall.This could replace the
Seriescall in Explore and improve the experience with high cardinality tenants.Also does a fair bit of refactoring to ensure we only define one Request/Response type between ingester/querier