Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Make clients options non global #667

Merged
merged 2 commits into from
May 9, 2023

Conversation

Rustin170506
Copy link
Contributor

Done the TODO. I think it is safe to move it into the new function.

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 6bf3825 into grafana:main May 9, 2023
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
* Make clients options non global

* Fix tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants