Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Add eslint as linter and prettier as formatter for app #677

Merged
merged 2 commits into from
May 15, 2023
Merged

Add eslint as linter and prettier as formatter for app #677

merged 2 commits into from
May 15, 2023

Conversation

Rustin170506
Copy link
Contributor

@Rustin170506 Rustin170506 commented May 11, 2023 •
edited
Loading

@Rustin170506 Rustin170506 force-pushed the rustin-patch-eslint branch 4 times, most recently from dbb00be to 04601f0 Compare May 14, 2023 15:36
@Rustin170506 Rustin170506 changed the title WIP: Add eslint as linter for app Add eslint as linter and prettier as formatter for app May 14, 2023
@Rustin170506 Rustin170506 force-pushed the rustin-patch-eslint branch from 2b25fd1 to d1c720c Compare May 14, 2023 15:49
@Rustin170506 Rustin170506 marked this pull request as ready for review May 14, 2023 15:50
@Rustin170506
Copy link
Contributor Author

@eh-am Could you please take a look at this PR? I added eslint as the linter and prettier as the formatter. I should have at least met the requirements of the issue. And I have GitHub Actions enabled. Thanks!

@Rustin170506 Rustin170506 force-pushed the rustin-patch-eslint branch from d1c720c to 48b6354 Compare May 15, 2023 00:36
Rustin170506
Rustin170506 commented May 15, 2023
View reviewed changes
Copy link
Contributor Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self check

eh-am
eh-am reviewed May 15, 2023
View reviewed changes
Copy link
Collaborator

@eh-am eh-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one small thing, imports to this repo can be aliased to @phlare, it makes the distinction more clear (what's from this repo, what's from pyroscope-oss etc).

scripts/webpack/webpack.common.js Outdated Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
@Rustin170506
Use @phlare
ecb0287 
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 requested a review from eh-am May 15, 2023 09:07
eh-am
eh-am approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@eh-am eh-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much <3 I know how painful is working with these things, so I really appreciate your work!

@eh-am eh-am merged commit fd65944 into grafana:main May 15, 2023
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@Rustin170506
build: add linter and formar checker to the frontend (grafana/phlare#677
ae48c9e 
)

* Add eslint as linter and prettier as formater for app

* Use @phlare

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eh-am eh-am eh-am approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[frontend] add linting
2 participants
@Rustin170506 @eh-am