Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Inline correctly the store-gateway config #752

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Inline correctly the store-gateway config #752

merged 1 commit into from
Jun 6, 2023

Conversation

cyriltovena
Copy link
Collaborator

This was a mistake from me, the config should be inline to avoid having the property config below store_gateway

kolesnikovae
kolesnikovae approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 7e331c2 into main Jun 6, 2023
@cyriltovena cyriltovena deleted the fix-store-gateway-config branch June 6, 2023 18:44
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@cyriltovena
Inline correctly the store-gateway config (grafana/phlare#752)
67dc534
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolesnikovae kolesnikovae kolesnikovae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriltovena @kolesnikovae