This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Fix concurrent map access in ingester #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Jun 9, 2023
|
Wonder if we should add --race to the test runner |
|
So this has re-introduced a bit of latency not as much as before though. I'll investigate if there's a better way before mergning |
|
Latest commit bring back tail latency to 50ms see below 
|
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Fix concurrent map access in ingester * Reduce the duration of the lock by only sweeping
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by faf62ed this was because before we were not flushing async and we would only sort/add profiles one at a time.