Create Plugin: Fix Code Coverage for JSX files #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jackw
added
create-plugin
jackw
reviewed
Jun 1, 2023
jest.config.base.js
Outdated
| @@ -4,7 +4,7 @@ module.exports = { | |||
| '^.+\\.(t|j)sx?$': [ | |||
| '@swc/jest', | |||
| { | |||
| sourceMaps: true, | |||
| sourceMaps: 'inline', | |||
There was a problem hiding this comment.
This is the jest config for the tests run against the create-plugin and sign-plugin source code rather than the jest config that is scaffolded for a plugin. Rather than make the change here could you please make it in packages/create-plugin/templates/common/.config/jest.config.js instead?
There was a problem hiding this comment.
Yeap. It was the wrong file.
Now I hope the changes are in the right file
jackw
approved these changes
Jun 1, 2023
jackw
changed the title
|
🚀 PR was released in |
grafana-delivery-bot
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changed to inline source maps for jest
Which issue(s) this PR fixes:
Fixes #267