Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upstream/remote support custom http client #101

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

hidu
Copy link
Contributor

@hidu hidu commented Apr 7, 2024

Now, upstream/remote uses *http.Client to send requests,
but it's difficult when discovery is not by domain

Copy link
Contributor

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @hidu! Could you please clarify the problem you've encountered? I'm asking because if this is something common that others may experience as well, we could probably extend the configuration options at the higher level.

@hidu
Copy link
Contributor Author

hidu commented Apr 8, 2024

I deploy Pyroscope on a cluster.
Client discovers the cluster through a naming service, which provides an IP list (and port) instead of domain names.
As instances of Pyroscope are subject to change, the IP list in the naming service will also change accordingly.

I also expect to use the custom client to print request/response logs, just like other clients in the Client APP.

@kolesnikovae kolesnikovae merged commit e1c67e3 into grafana:main Apr 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants