Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(godeltaprof): incorrect function names for generics functions #106

Merged
merged 3 commits into from
May 22, 2024

Conversation

korniltsev
Copy link
Collaborator

@korniltsev korniltsev commented May 21, 2024

Fixes #82

This PR ports fixes from upstream for the following issues golang/go#64528 and golang/go#64641

Specifically golang/go@20a03fc and golang/go@d95e25e

@korniltsev korniltsev changed the title Godeltaprof generics backport fix(godeltaprof): incorrect function names for generics functions May 21, 2024
@korniltsev
Copy link
Collaborator Author

gotip will be fixed in a separate PR as this is a different issue

Copy link

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for getting this fixed upstream and here 🙂

@korniltsev
Copy link
Collaborator Author

double trouble 👯

@korniltsev korniltsev merged commit ffd2615 into main May 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

godeltaprof (and golang runtime) sometimes incorrectly outputs generic function names
2 participants