Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency "p-limit" in package.json #102

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

zckrs
Copy link
Contributor

@zckrs zckrs commented Oct 7, 2024

No description provided.

@zckrs zckrs requested review from a team as code owners October 7, 2024 13:05
@zckrs
Copy link
Contributor Author

zckrs commented Oct 9, 2024

Can someone can release this PR ? @simonswine @nwalters512

@korniltsev
Copy link
Collaborator

@zckrs Can you provide some more info? Why do we need this? Did you get any errors?

@korniltsev
Copy link
Collaborator

Should we also update yarn.lock ?

@zckrs
Copy link
Contributor Author

zckrs commented Oct 9, 2024

Sorry for missing informations.

In

import pLimit from 'p-limit';
p-limit is used but is not present in package.json.

npm doesnt install the pacakge in most case with a small project.

For example in our prod environnement with npm install --only=production

Cannot find module 'p-limit'Require stack:
- /src/node_modules/@pyroscope/nodejs/dist/cjs/sourcemapper.js
- /src/node_modules/@pyroscope/nodejs/dist/cjs/index.js
- /src/node_modules/our-express/src/boot/pyroscope.js
- /src/node_modules/our-express/src/index.js
- /src/server/server.js
- /src/server/reader.js Require stack: 
- node_modules/@pyroscope/nodejs/dist/cjs/sourcemapper.js 
- node_modules/@pyroscope/nodejs/dist/cjs/index.js 
- node_modules/our-express/src/boot/pyroscope.js 
- node_modules/our-express/src/index.js 
- server/server.js 
- server/reader.js at Module._resolveFilename (node:internal/modules/cjs/loader:1225:15) at Module._load (node:internal/modules/cjs/loader:1051:27) at Module.require (node:internal/modules/cjs/loader:1311:19) at require (node:internal/modules/helpers:179:18) at Object.<anonymous> (node_modules/@pyroscope/nodejs/dist/cjs/sourcemapper.js:54:35) at Module._compile (node:internal/modules/cjs/loader:1469:14) at Module._extensions..js (node:internal/modules/cjs/loader:1548:10) at Module.load (node:internal/modules/cjs/loader:1288:32) at Module._load (node:internal/modules/cjs/loader:1104:12) at Module.require (node:internal/modules/cjs/loader:1311:19)

@zckrs
Copy link
Contributor Author

zckrs commented Oct 9, 2024

@korniltsev korniltsev merged commit 9fc88fa into grafana:main Oct 9, 2024
6 checks passed
@zckrs zckrs deleted the patch-1 branch October 9, 2024 12:33
@zckrs
Copy link
Contributor Author

zckrs commented Oct 10, 2024

Do you plan to release a patch version ?

@zckrs
Copy link
Contributor Author

zckrs commented Oct 15, 2024

Please release a 0.4.1 🙏 @korniltsev

@bryanhuhta bryanhuhta mentioned this pull request Oct 16, 2024
@bryanhuhta
Copy link
Contributor

@zckrs I just release v0.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants