-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency "p-limit" in package.json #102
Conversation
Can someone can release this PR ? @simonswine @nwalters512 |
@zckrs Can you provide some more info? Why do we need this? Did you get any errors? |
Should we also update yarn.lock ? |
Sorry for missing informations. In pyroscope-nodejs/src/sourcemapper.ts Line 27 in 663a557
p-limit is used but is not present in package.json.
npm doesnt install the pacakge in most case with a small project. For example in our prod environnement with
|
yarn.lock looks good https://github.com/grafana/pyroscope-nodejs/blob/main/yarn.lock#L1898 |
Do you plan to release a patch version ? |
Please release a 0.4.1 🙏 @korniltsev |
No description provided.