Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(update-contributors): do not skip CI #3556

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore(update-contributors): do not skip CI #3556

merged 1 commit into from
Sep 18, 2024

Conversation

korniltsev
Copy link
Collaborator

[skip ci] may prevent running goreleaser

@korniltsev korniltsev requested a review from a team as a code owner September 13, 2024 01:38
marcsanmi
marcsanmi reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? AFAIU we only release from specific branches and tags, isn't it?

@marcsanmi marcsanmi requested a review from a team September 17, 2024 16:36
@korniltsev
Copy link
Collaborator Author

korniltsev commented Sep 18, 2024 •
edited
Loading

image
It happened to me when I created release branch. It did not run goreleaser until I touched something in the branch

@korniltsev korniltsev enabled auto-merge (squash) September 18, 2024 00:45
marcsanmi
marcsanmi approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, just to keep in mind that this change will trigger the CI, including image builds, for every README update.

@korniltsev korniltsev merged commit e56265f into main Sep 18, 2024
18 checks passed
@korniltsev korniltsev deleted the korniltsev/update-contributors-noskip-ci branch September 18, 2024 07:53
@korniltsev
Copy link
Collaborator Author

korniltsev commented Sep 18, 2024 •
edited
Loading

for every README update.

only weekly / release branches

alsoba13 pushed a commit that referenced this pull request Sep 19, 2024
@korniltsev @alsoba13
chore(update-contributors): do not skip ci (#3556)
a8509a9
alsoba13 pushed a commit that referenced this pull request Sep 19, 2024
@korniltsev @alsoba13
chore(update-contributors): do not skip ci (#3556)
deb1f91
alsoba13 pushed a commit that referenced this pull request Sep 19, 2024
@korniltsev @alsoba13
chore(update-contributors): do not skip ci (#3556)
6958c22
alsoba13 pushed a commit that referenced this pull request Sep 19, 2024
@korniltsev @alsoba13
chore(update-contributors): do not skip ci (#3556)
05da3e9
alsoba13 pushed a commit that referenced this pull request Sep 19, 2024
@korniltsev @alsoba13
chore(update-contributors): do not skip ci (#3556)
903867b
alsoba13 pushed a commit that referenced this pull request Sep 19, 2024
@korniltsev @alsoba13
chore(update-contributors): do not skip ci (#3556)
14a4cd1
@aleks-p aleks-p mentioned this pull request Sep 19, 2024
Closed
alsoba13 pushed a commit that referenced this pull request Sep 20, 2024
@korniltsev @alsoba13
chore(update-contributors): do not skip ci (#3556)
345f4ba
marcsanmi added a commit that referenced this pull request Sep 20, 2024
@marcsanmi
Revert "chore(update-contributors): do not skip ci (#3556)"
f57ea2d 
This reverts commit e56265f.
marcsanmi added a commit that referenced this pull request Sep 20, 2024
@marcsanmi
Revert "chore(update-contributors): do not skip ci (#3556)" (#3577)
cd159db 
This reverts commit e56265f.
alsoba13 pushed a commit that referenced this pull request Sep 25, 2024
@korniltsev @alsoba13
chore(update-contributors): do not skip ci (#3556)
e092515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcsanmi marcsanmi marcsanmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korniltsev @marcsanmi