fix(v2): retry compaction polling requests on Raft leader errors #3562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
reviewed
Sep 17, 2024
korniltsev
approved these changes
Sep 18, 2024
kolesnikovae
approved these changes
Sep 18, 2024
pkg/experiment/metastore/metastore_state_poll_compaction_jobs.go
Outdated
Show resolved
Hide resolved
aleks-p
force-pushed
the
fix/compaction-polling-raft-retries
branch
from
3b10a46
to
b23d844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue where compaction workers continue making requests to the wrong Raft node following a leadership transfer. We could alternatively move this to
applyCommandbut I will leave that for a future iteration.