Variables: Add new allowCustomValue flag to MultiVariables
#956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mdvictor
added
minor
mdvictor
requested review from
axelavargas,
bfmatei,
ashharrison90 and
Sergej-Vlasov
harisrozajac
approved these changes
Nov 8, 2024
| @@ -40,7 +40,7 @@ export function toSelectableValue<T>(value: T, label?: string): SelectableValue< | |||
| } | |||
|
|
|||
| export function VariableValueSelect({ model }: SceneComponentProps<MultiValueVariable>) { | |||
| const { value, text, key, options, includeAll, isReadOnly } = model.useState(); | |||
| const { value, text, key, options, includeAll, isReadOnly, allowCustomValue } = model.useState(); | |||
There was a problem hiding this comment.
Just a small nit that you can disregard, but I thought it would be nice to just initialize allowCustomValue = true since it's same as allowCustomValue ?? true on L83
There was a problem hiding this comment.
True, thank you for leaving this! It is nicer indeed! Just updated it.
| @@ -101,7 +101,7 @@ export function VariableValueSelect({ model }: SceneComponentProps<MultiValueVar | |||
| } | |||
|
|
|||
| export function VariableValueSelectMulti({ model }: SceneComponentProps<MultiValueVariable>) { | |||
| const { value, options, key, maxVisibleValues, noValueOnClear, includeAll, isReadOnly } = model.useState(); | |||
| const { value, options, key, maxVisibleValues, noValueOnClear, includeAll, isReadOnly, allowCustomValue } = model.useState(); | |||
Co-authored-by: Sergej-Vlasov <sergej.s.vlasov@gmail.com>
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are a feature request to offer the ability to select whether a variable can support custom values or just lock the options list to contain only queried option values. This change is needed in scenes to offer the functionality in dashboards.
Since we currently allow custom values by default, we maintain this default but offer the option to disable the flag in dashboards variable settings.
Related PR
📦 Published PR as canary version:
5.24.0--canary.956.11779891409.0✨ Test out this PR locally via:
npm install @grafana/scenes-react@5.24.0--canary.956.11779891409.0 npm install @grafana/scenes@5.24.0--canary.956.11779891409.0 # or yarn add @grafana/scenes-react@5.24.0--canary.956.11779891409.0 yarn add @grafana/scenes@5.24.0--canary.956.11779891409.0