Variables: Saved default all value with non multi select fix #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
added
patch
axelavargas
approved these changes
Nov 8, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes grafana/grafana#96027
The issue seems to be that both text & value are initialized to ALL_VARIABLE_VALUE, and in case the Select is not a multi value the correct label is not shown
Think this could fix it
📦 Published PR as canary version:
5.23.2--canary.959.11726132276.0✨ Test out this PR locally via:
npm install @grafana/scenes-react@5.23.2--canary.959.11726132276.0 npm install @grafana/scenes@5.23.2--canary.959.11726132276.0 # or yarn add @grafana/scenes-react@5.23.2--canary.959.11726132276.0 yarn add @grafana/scenes@5.23.2--canary.959.11726132276.0