Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the OTLP HTTP port in the distributor service #610

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

andreasgerstmayr
Copy link
Collaborator

Required e.g. for running the hotrod example application

$ docker run --network=host -e OTEL_EXPORTER_OTLP_ENDPOINT=http://tempo-simplest-distributor.default.svc.cluster.local:4318 jaegertracing/example-hotrod:1.46 all --otel-exporter=otlp

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (de2a529) 78.20% compared to head (e83f625) 78.25%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   78.20%   78.25%   +0.05%     
==========================================
  Files          64       64              
  Lines        4781     4792      +11     
==========================================
+ Hits         3739     3750      +11     
  Misses        864      864              
  Partials      178      178              
Flag Coverage Δ
unittests 78.25% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/manifests/distributor/distributor.go 94.52% <100.00%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui :D

@frzifus frzifus merged commit 43fbf44 into grafana:main Sep 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants