Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support object storage in TempoMonolithic CR #763

Conversation

andreasgerstmayr
Copy link
Collaborator

@andreasgerstmayr andreasgerstmayr commented Jan 25, 2024

Support object storage in TempoMonolithic CR

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 292 lines in your changes are missing coverage. Please review.

Comparison is base (0afce6a) 75.08% compared to head (f23c45d) 73.72%.

Files Patch % Lines
internal/handlers/storage/storage.go 0.00% 125 Missing ⚠️
internal/handlers/storage/secret.go 37.64% 50 Missing and 3 partials ⚠️
internal/manifests/monolithic/statefulset.go 55.88% 27 Missing and 3 partials ⚠️
internal/handlers/storage/tls.go 0.00% 28 Missing ⚠️
internal/manifests/monolithic/configmap.go 21.87% 25 Missing ⚠️
internal/webhooks/tempomonolithic_webhook.go 0.00% 11 Missing ⚠️
cmd/generate/main.go 36.36% 7 Missing ⚠️
internal/manifests/config/build.go 58.82% 5 Missing and 2 partials ⚠️
controllers/tempo/tempomonolithic_controller.go 57.14% 2 Missing and 1 partial ⚠️
internal/upgrade/v0_8_0.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
- Coverage   75.08%   73.72%   -1.37%     
==========================================
  Files          79       82       +3     
  Lines        5917     6039     +122     
==========================================
+ Hits         4443     4452       +9     
- Misses       1249     1358     +109     
- Partials      225      229       +4     
Flag Coverage Δ
unittests 73.72% <38.65%> (-1.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasgerstmayr andreasgerstmayr force-pushed the tempo-monolithic-object-storage branch 2 times, most recently from 5309d49 to 96f7538 Compare January 26, 2024 19:27
@andreasgerstmayr andreasgerstmayr force-pushed the tempo-monolithic-object-storage branch 4 times, most recently from 7509f5d to 9502c30 Compare February 1, 2024 10:57
@andreasgerstmayr andreasgerstmayr marked this pull request as ready for review February 1, 2024 10:57
@andreasgerstmayr andreasgerstmayr force-pushed the tempo-monolithic-object-storage branch 3 times, most recently from 1a677a7 to f8f37d0 Compare February 1, 2024 16:01
* unify storage secret, storage TLS and storage credentials mounting

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr force-pushed the tempo-monolithic-object-storage branch from f8f37d0 to 2cec1ad Compare February 1, 2024 16:44
If, for some case, the defaults were not applied.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr enabled auto-merge (squash) February 1, 2024 16:52
@andreasgerstmayr andreasgerstmayr merged commit 92168e2 into grafana:main Feb 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants