Support configuring resource requests and limits in TempoMonolithic CR #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasgerstmayr
force-pushed
the
tempo-monolithic-resource-limits
branch
2 times, most recently
from
6d087b6 to
24355ed
Compare
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
andreasgerstmayr
force-pushed
the
tempo-monolithic-resource-limits
branch
from
24355ed to
b7899d1
Compare
pavolloffay
approved these changes
Feb 1, 2024
| // S3 defines the AWS S3 configuration | ||
| // | ||
| // +kubebuilder:validation:Optional | ||
| S3 *MonolithicTracesStorageS3Spec `json:"s3,omitempty"` |
There was a problem hiding this comment.
these changes seem to be unrelated to the resources. Can it be done in a separate PR?
There was a problem hiding this comment.
I think it was a change before I rebased on main. The change doesn't show up in the diff anymore.
| @@ -135,6 +182,7 @@ type MonolithicIngestionOTLPProtocolsHTTPSpec struct { | |||
| // Enabled defines if OTLP over HTTP is enabled | |||
| // | |||
| // +kubebuilder:validation:Required | |||
| // +kubebuilder:default=true | |||
There was a problem hiding this comment.
also this one seems to be unrelated
There was a problem hiding this comment.
I think it was a change before I rebased on main. The change doesn't show up in the diff anymore.
internal/handlers/storage/storage.go
Outdated
| ) | ||
|
|
||
| // ListFieldErrors converts field.ErrorList to a comma separated string of errors. | ||
| func ListFieldErrors(fieldErrs field.ErrorList) string { |
There was a problem hiding this comment.
does this need to be exposed?
There was a problem hiding this comment.
It's used in the controller package. I'll move it there.
There was a problem hiding this comment.
Done: #772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support configuring resource requests and limits in TempoMonolithic CR