Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom ServiceAccount in TempoMonolithic CR #836

Merged

Conversation

andreasgerstmayr
Copy link
Collaborator

Support custom ServiceAccount in TempoMonolithic CR

Depends on #815

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 75.03%. Comparing base (13e07bf) to head (1810e2c).

Files Patch % Lines
internal/webhooks/tempomonolithic_webhook.go 54.54% 10 Missing ⚠️
controllers/tempo/tempomonolithic_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   75.09%   75.03%   -0.06%     
==========================================
  Files          89       89              
  Lines        6440     6469      +29     
==========================================
+ Hits         4836     4854      +18     
- Misses       1367     1378      +11     
  Partials      237      237              
Flag Coverage Δ
unittests 75.03% <65.62%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr andreasgerstmayr changed the title Support custom ServiceAccount in TempoMonolithic CR (depends on #815) Support custom ServiceAccount in TempoMonolithic CR Mar 11, 2024
@andreasgerstmayr andreasgerstmayr merged commit a9f687e into grafana:main Mar 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants