Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenant index improvements #1005

Merged
merged 7 commits into from
Oct 4, 2021

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Oct 4, 2021

What this PR does:

  • Adds a new config option to control how old an index has to be to be considered stale: blocklist_poll_stale_tenant_index.
    This defaults to 0 (disabled).
  • Update runbooks/documentation/alerts accordingly
  • Shards the job of building tenant indexes across all compactors to reduce load on a single compactor.
  • Ninja fix "job_selectors" in the tempo-mixin from ['namespace', 'job'] => ['cluster', 'namespace', 'job'],

Which issue(s) this PR fixes:
Fixes #866
Fixes #867

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit 49c0d63 into grafana:main Oct 4, 2021
KMiller-Grafana added a commit to KMiller-Grafana/tempo that referenced this pull request Oct 5, 2021
This PR improves the docs associated with blocklist_poll_stale_tenant_index.
grafana#1005 was merged in without a
doc review.
joe-elliott pushed a commit that referenced this pull request Oct 5, 2021
This PR improves the docs associated with blocklist_poll_stale_tenant_index.
#1005 was merged in without a
doc review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback to Polling Based on Tenant Index Age Shard Tenant Index Builders by Tenant
2 participants