Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Prometheus/Cortex/Thanos/GRPC dependencies #1186

Merged
merged 10 commits into from
Jan 7, 2022

Conversation

annanay25
Copy link
Contributor

@annanay25 annanay25 commented Dec 22, 2021

Signed-off-by: Annanay annanayagarwal@gmail.com

What this PR does:
Updating dependencies for use by downstream repositories.

  • Prometheus updates were done to catch some refactoring done here Move packages out of deprecated pkg directory prometheus/prometheus#9478

  • Cortex was updated to use the updated directory structure in Prometheus ^
    Changes: cortexproject/cortex@3f329a2...07d6cfc
    Does not look like there's any concerning changes.

  • Thanos was updated to use the updated directory structure in Prometheus ^
    Changes: thanos-io/thanos@c15594a...d1acaea

  • Minio update is a downstream requirement

  • ⚠️ GRPC update⚠️
    GRPC 1.33.3 => 1.38.0 broke compatibility with gogoproto.customtype. We use a customtype in the ingesters to pre-allocate byte slices that are reused for requests. To get past this, we enforce the use of gogoproto marshalling/unmarshalling for Tempo, Cortex & Jaeger structs.

Which issue(s) this PR fixes:
Fixes #na

Checklist

  • NA Tests updated
  • NA Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25 annanay25 marked this pull request as ready for review January 6, 2022 07:46
pkg/gogocodec/gogocodec.go Outdated Show resolved Hide resolved
modules/ingester/ingester.go Show resolved Hide resolved
Signed-off-by: Annanay <annanayagarwal@gmail.com>
…er dereference

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants