Service graphs: add dimensions and rename expired edges metric #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
requested review from
joe-elliott,
annanay25,
mdisibio,
dgzlopes,
yvrhdn and
zalegrala
as code owners
26 tasks
mapno
force-pushed
the
servicegraphs-improvements
branch
from
8d43475 to
5577aac
Compare
yvrhdn
reviewed
Apr 5, 2022
Add dimensions to the service graphs processor config, which attaches additional labels to the metrics from spans attributes. It also renames the expired edges internal metric.
mapno
force-pushed
the
servicegraphs-improvements
branch
from
309793e to
9698163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dimensions to the service graphs processor config, which attaches
additional labels to the metrics from spans attributes.
It also renames the expired edges internal metric.