metrics-generator: emit exemplars #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Service graphs with exemplars 🎉
Span metrics with exemplars 🎉
|
yvrhdn
force-pushed
the
kvrhdn/metrics-geneator-exemplars
branch
from
d18c5ff to
c56bfdf
Compare
yvrhdn
requested review from
joe-elliott,
annanay25,
mdisibio,
dgzlopes,
mapno and
zalegrala
as code owners
mapno
approved these changes
Apr 6, 2022
| // TODO support exemplars | ||
| //ObserveWithExemplar(lbls labels.Labels, value float64, exemplarLbls labels.Labels) | ||
| // Observe a datapoint with the given values. traceID will be added as exemplar. | ||
| Observe(values *LabelValues, value float64, traceID string) |
There was a problem hiding this comment.
Why not use similar interface as Prometheus: Observe and ObserveWithExemplar?
There was a problem hiding this comment.
I originally had both functions but then noticed that we never use Observe. If we don't use it, why bother supporting it? 🤷🏻
I'm guessing that we will always have a traceID available since every metric is based upon trace data. If at some point this isn't the case anymore we can add the original observe function again.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Follow up from #1340 and adds the capability to capture and remote write exemplar.
Which issue(s) this PR fixes:
Related to #1303
Checklist
Documentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]