Metrics generator docker compose #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
requested review from
joe-elliott,
annanay25,
mdisibio,
dgzlopes,
yvrhdn and
zalegrala
as code owners
yvrhdn
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Left some comments but non are blocking. LGTM!
Also about exemplars, in the distributed example I configured links from Prometheus to Tempo:
tempo/example/docker-compose/distributed/grafana-datasources.yaml
Lines 13 to 16 in e2f7b9c
I think we can simply copy this over to the shared/grafana-datasources.yaml.
Comment on lines
-101
to
-102
| ringCfg := cfg.Ring.ToRingConfig() | ||
| g.ring, err = ring.NewWithStoreClientAndStrategy(ringCfg, ringNameForServer, RingKey, ringStore, ring.NewIgnoreUnhealthyInstancesReplicationStrategy(), prometheus.WrapRegistererWithPrefix("cortex_", reg), g.logger) |
There was a problem hiding this comment.
Nice find! 🙌🏻 I did not know just the lifecycler was enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
localdocker-compose exampleWhich issue(s) this PR fixes:
Contributes to #1303