-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tracing integration to profiling. #3276
Conversation
Not sure why windows build is failing.
|
@cyriltovena I saw that you checked the Documentation added box. Did you update doc or just add the changelog entry? If the latter, we can make a doc issue to update the Tempo doc and other doc sets, as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good but I think you need to run:
make update-mod
to tidy up the serverless go.mods
I don't think this needs to be mentioned in the doc. This is why I checked that box. I think a changelog entry is enough yes. |
We are getting this on other PRs too. This fix works locally, I will test it on my PR:
|
Same as grafana/tempo#3276 this adds profiling integration to tracing instrumentation allowing to get profile for a single request removing the noise of everything else.
@mdisibio should be good now thanks ! |
hey that's seems stale ? |
@cyriltovena i'm good on this PR. if you can work out the conflicts we'll merge |
Same as grafana/tempo#3276 this adds profiling integration to tracing instrumentation allowing to get profile for a single request removing the noise of everything else.
What this PR does:
This adds tracing integration to pprof profiling. Every root span ID per service will be added to the profiling data using pprof labels and then forward to Pyroscope.
This allows to show flamegraph for a given trace
Which can be useful to understand resource usage per trace.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]