Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back localblocks filtering with config option #3303

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Jan 17, 2024

What this PR does:

Here we bring back the localblocks processor filtering for kind==server, but with a config option to modify the code path.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zalegrala zalegrala merged commit 41c3d65 into grafana:main Jan 17, 2024
15 checks passed
Copy link
Contributor

Hello @mdisibio!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@mdisibio mdisibio added the type/bug Something isn't working label Jan 22, 2024
mdisibio added a commit to mdisibio/tempo that referenced this pull request Jan 22, 2024
mdisibio added a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport r131 type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants