-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Traceql metrics] New (unsafe) query hints #3396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
About dedup
, it might be safe but do we want users passing this hint to Tempo? Is there a use case other than for operators to tune compaction?
Right, there isn't really a use-case for it besides tuning compaction. Currently it's faster to not dedupe, so you could trade accuracy for speed, but that should go away after we change dedupe to loser-tree.
|
…ncurrent_blocks to match naming convention of other concurrent_* fields.
@mapno This is ready for re-review. Centralized all of the hint definitions and safety to the traceql package, exposed config options for concurrent_blocks and time_overlap_cutoff, and moved dedupe to be unsafe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Adds several new query hints which expose traditionally server-side config options. These are useful for operators (like us) to try out and quickly optimize tuneables like job size, sharding interval, and concurrency etc. But because these are unsafe to expose to end-users they are protected behind a per-tenant override flag. For example a job size of 1 byte would quickly take out the read path.
Safe hint:
The only safe hint is the existing
sample=<float>
.Unsafe hints:
dedupe=<bool>
job_size=<int>
target_bytes_per_request
. Default = configured in yamljob_interval=<duration>
interval
. Default = configured in yamlconcurrent_blocks=<int>
time_overlap_cutoff=<float>
Requires #3388
Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]