[TraceQL Metrics] Fix handling of empties and nils + other fixes #3440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Basically this overhauls the handling of timeseries labels for metrics queries. There are several fixes in here, but it also lines up behavior with: grafana/grafana#83619
{rootName=""} | rate() by (rootName)
. This would look like a completely empty labelset in the response and cause issues downstream. Now it's preserved as the single labelrootName
with an empty string value.{}
in the Tempo UI and the query name in the Prometheus UI (a fallback method). Note: theEmitDefaults:true
is part of this so that Tempo always outputs an empty array in the json (and not nil).Which issue(s) this PR fixes:
Fixes #3429
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]