[Traceql] Add support for searching by trace:id and span:id #3670
Conversation
| @@ -999,7 +1000,7 @@ func createSpanIterator(makeIter makeIterFn, primaryIter parquetquery.Iterator, | |||
| switch cond.Attribute.Intrinsic { | |||
| case traceql.IntrinsicSpanID: | |||
|
|
|||
| pred, err := createStringPredicate(cond.Op, cond.Operands) | |||
| pred, err := createBytesPredicate(cond.Op, cond.Operands, true) | |||
There was a problem hiding this comment.
placeholder until #3667 is merged with the new predicates
There was a problem hiding this comment.
The new predicates will not have a bytes predicate. I would just write a new one in pkg/parquetquery/predicates.go.
There was a problem hiding this comment.
Since the string predicate actually uses bytes array, reusing the string predicate works well. Any concerns about this?
There was a problem hiding this comment.
nope. not if it does what we want
pkg/util/traceid.go
Outdated
| @@ -9,7 +9,7 @@ import ( | |||
| "unsafe" | |||
| ) | |||
|
|
|||
| func HexStringToTraceID(id string) ([]byte, error) { | |||
| func HexStringToID(id string, isSpan bool) ([]byte, error) { | |||
There was a problem hiding this comment.
The function HexStringToID() is no longer used outside this package (and probably should no longer be used, as it has merely become a helper function). Consider making the function private and maybe move it below the functions HexStringToTraceID() and HexStringToSpanID()
|
When I use an ID string that is too long when querying or This is of course not wrong. But I'm wondering whether it would be better to just not return any matches |
ie-pham
changed the title
ie-pham
requested review from
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala and
electron0zero
as code owners
What this PR does: Add support for searching by trace:id and span:id. One thing to note is that when comparing bytes array, Tempo will left trim "x00". This means that
[]byte{0x02} == []byte{0x00, 0x02}Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]