TraceQL event intrinsic event:name

[stoewer]

What this PR does:

Add event scope and the intrinsic event:name

Autocomplete is currently not working, but is also part of a separate issue.

Which issue(s) this PR fixes:
Contributes to grafana/tempo-squad#424

Checklist

• Tests updated
• Documentation added
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[stoewer]

Local tests with docker-compose examples

[stoewer]

There are two behaviors that I'm not quite sure about. It would be great to get feedback about them

1. The query { event:name != "exception" } also returns spans without any events at all. Is this correct or should we only return spans with events that don't have the specified name?
2. When running a with query:name on vParquet2 or vParquet3 it shows the following error: "rpc error: code = Internal desc = error querying ingesters in Querier.Search: failed to execute f() for 127.0.0.1:9095: rpc error: code = Unknown desc = creating fetch iter: error creating iterator: unsupported traceql scope: event:name". Do we want to show this error, or should we rather just show no results? see here

[mdisibio]

Since this isn't supported in vParquet2/3, I think we need to ensure that a query using event intrinsics doesn't execute. Currently, it looks like the condition will be silently dropped while fetching, which means the query results could be incorrect: the {name=x && event:name=y} will be executed against a vp2/3 block as {name=x}. checkConditions could return ErrUnsupported if any event scope condition is present. Didn't see if this is caught elsewhere.

[stoewer]

Currently queries with event:name fail in categorizeConditions() which results in a rather cryptic error reported in the UI. I agree, it's much better to check this explicitly in checkConditions() and wrap ErrUnsupported.

[mdisibio]

nit: let's create a const for the definitionlevel=4

[ie-pham]

LGTM! Awesome work! Will steal this for my PR 😄

Nit: May I suggest a test in block_traceql_meta_test.go ?

{
			"Event name lookup",
			makeReq(
				parse(t, `{event:name = "e1"}`), // 
			),
			makeSpansets(
				makeSpanset(
					wantTr.TraceID,
					wantTr.RootSpanName,
					wantTr.RootServiceName,
					wantTr.StartTimeUnixNano,
					wantTr.DurationNano,
					&span{
						id:                 wantTr.ResourceSpans[0].ScopeSpans[0].Spans[0].SpanID,
						startTimeUnixNanos: wantTr.ResourceSpans[0].ScopeSpans[0].Spans[0].StartTimeUnixNano,
						durationNanos:      wantTr.ResourceSpans[0].ScopeSpans[0].Spans[0].DurationNano,
						spanAttrs: []attrVal{
							{traceql.NewIntrinsic(traceql.IntrinsicDuration), traceql.NewStaticDuration(100 * time.Second)},
							{traceql.NewIntrinsic(traceql.IntrinsicSpanID), traceql.NewStaticString(util.SpanIDToHexString(wantTr.ResourceSpans[0].ScopeSpans[0].Spans[0].SpanID))},
						},
						traceAttrs: []attrVal{
							{traceql.NewIntrinsic(traceql.IntrinsicTraceRootService), traceql.NewStaticString("RootService")},
							{traceql.NewIntrinsic(traceql.IntrinsicTraceRootSpan), traceql.NewStaticString("RootSpan")},
							{traceql.NewIntrinsic(traceql.IntrinsicTraceDuration), traceql.NewStaticDuration(100 * time.Millisecond)},
							{traceql.NewIntrinsic(traceql.IntrinsicTraceID), traceql.NewStaticString(util.TraceIDToHexString(wantTr.TraceID))},
						},
						eventAttrs: []attrVal{
							{traceql.NewIntrinsic(traceql.IntrinsicEventName), traceql.NewStaticString("e1")},
						},
					},
				),
			),
		},

[stoewer]

May I suggest a test in block_traceql_meta_test.go?

Good point, thank you. I've added the test case