Query-frontend: Parrallelize unmarshalling of responses #3713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
requested review from
knylander-grafana,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mapno
approved these changes
May 28, 2024
3 tasks
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
force-pushed
the
parrallelize-combine
branch
from
d1dc786
to
b15ef98
Compare
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
|
Fixed a flakey test and add http status code to the logged response on searches. |
mapno
approved these changes
Jun 4, 2024
Signed-off-by: Joe Elliott <number101010@gmail.com>
mapno
pushed a commit
that referenced
this pull request
Jun 6, 2024
* Add combiner does not race test Signed-off-by: Joe Elliott <number101010@gmail.com> * make unmarshal in combiner //able Signed-off-by: Joe Elliott <number101010@gmail.com> * wip: one test failing Signed-off-by: Joe Elliott <number101010@gmail.com> * store first err Signed-off-by: Joe Elliott <number101010@gmail.com> * config Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com> * enhance Signed-off-by: Joe Elliott <number101010@gmail.com> * lint n' stuff Signed-off-by: Joe Elliott <number101010@gmail.com> * addNextAsync -> consumeAndCombineResponses Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race Signed-off-by: Joe Elliott <number101010@gmail.com> * fixed test Signed-off-by: Joe Elliott <number101010@gmail.com> * fix race Signed-off-by: Joe Elliott <number101010@gmail.com> * test to confirm errors are held Signed-off-by: Joe Elliott <number101010@gmail.com> --------- Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a configurable number of dedicated goroutines per request to consume the responses and add them to the combiner. The combiner was also adjusted to move the unmarshalling steps outside of the locking logic so we could do multiple unmarshals in parrallel.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]