Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autocomplete_filtering_enabled config flag #3729

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

mapno
Copy link
Member

@mapno mapno commented May 29, 2024

What this PR does:

Removes autocomplete_filtering_enabled feature flag. It defaulted to true since Nov '23 (#3178) and was mainly used to disable the feature if performance was bad.

We haven't had to turn it off since a long time ago and we're now happy with its performance.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mapno mapno changed the title Remove autocomplete_filtering_enabled config flag Remove autocomplete_filtering_enabled config flag May 29, 2024
@mapno mapno marked this pull request as ready for review May 29, 2024 13:28
@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label May 29, 2024
@mapno mapno enabled auto-merge (squash) June 21, 2024 13:04
@mapno mapno merged commit 2a38bd1 into grafana:main Jun 21, 2024
15 checks passed
@mapno mapno deleted the deprecate-autocomplete-filtering-flag branch June 21, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants