Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native histograms for internal metrics #3870

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Jul 16, 2024

What this PR does:

Here we include the necessary options for the Prometheus client to expose
native histograms for internal metrics. Users will need to scrape the native
histograms explicitly, but this will allow a migration to begin. There will be
some follow up to add the necessary changes to dashboards etc, but here we can
begin the process.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zalegrala zalegrala changed the title Poller native histogram Add native histograms for internal metrics Jul 16, 2024
@zalegrala zalegrala marked this pull request as ready for review July 17, 2024 14:32
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good.

i don't know enough about the provided options to comment. does it make sense to keep them all independent like this? will we often want to make adjustments per histogram or should we just make one place to set them like:

func nativeHistoOpts(o prometheus.HistogramOpts) prometheus.HistogramOpts {
  // set native histo opts

  return o
}

@zalegrala
Copy link
Contributor Author

My impression is that we won't make changes to these often, and if we do, they might not align in the same way. I don't mind the change you suggest, but not sure its worth it right now.

@zalegrala zalegrala merged commit 1c62226 into grafana:main Jul 19, 2024
14 checks passed
@zalegrala zalegrala deleted the pollerNativeHistogram branch August 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants