Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make vendor-check #3910

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix make vendor-check #3910

merged 1 commit into from
Jul 26, 2024

Conversation

shalk
Copy link
Contributor

@shalk shalk commented Jul 25, 2024

What this PR does:

Which issue(s) this PR fixes:
Fixes #3905

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i saw the issue, but i'd prefer to keep using a container to run yacc instead of requiring everyone to install yacc locally.

@shalk
Copy link
Contributor Author

shalk commented Jul 25, 2024

i saw the issue, but i'd prefer to keep using a container to run yacc instead of requiring everyone to install yacc locally.

I keep the container, and i found the golang version in grafana/loki-build-image:0.21.0 is too low.
loki-build-image 0.33.2 's golang version is 1.22.5
It works.

But I think it is hard to keep the version consistent with loki-build-image. should we use golang:1.22 instead ?

@javiermolinar
Copy link
Contributor

i saw the issue, but i'd prefer to keep using a container to run yacc instead of requiring everyone to install yacc locally.

I keep the container, and i found the golang version in grafana/loki-build-image:0.21.0 is too low. loki-build-image 0.33.2 's golang version is 1.22.5 It works.

But I think it is hard to keep the version consistent with loki-build-image. should we use golang:1.22 instead ?

Maybe Tempo should have it's own build image

@shalk shalk requested a review from joe-elliott July 25, 2024 12:33
@joe-elliott
Copy link
Member

loki-build-image 0.33.2 's golang version is 1.22.5
It works.

Let's just update to 0.33.2 if that works.

should we use golang:1.22 instead ?

I honestly don't know how floating the patch works in a go.mod.

Maybe Tempo should have it's own build image

When/if we need to we can make our own. Otherwise we may as well share work with Loki.

@shalk
Copy link
Contributor Author

shalk commented Jul 25, 2024

loki-build-image 0.33.2 's golang version is 1.22.5
It works.

Let's just update to 0.33.2 if that works.

should we use golang:1.22 instead ?

I honestly don't know how floating the patch works in a go.mod.

Maybe Tempo should have it's own build image

When/if we need to we can make our own. Otherwise we may as well share work with Loki.

done

@shalk shalk force-pushed the fix-vendor-check branch from 6f85620 to 6cfa268 Compare July 26, 2024 09:45
@joe-elliott
Copy link
Member

Thanks for the fix!

@joe-elliott joe-elliott merged commit ca5fdae into grafana:main Jul 26, 2024
14 checks passed
@shalk shalk deleted the fix-vendor-check branch July 27, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile issue when make vendor-check
3 participants