-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix make vendor-check #3910
fix make vendor-check #3910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i saw the issue, but i'd prefer to keep using a container to run yacc instead of requiring everyone to install yacc locally.
I keep the container, and i found the golang version in grafana/loki-build-image:0.21.0 is too low. But I think it is hard to keep the version consistent with loki-build-image. should we use golang:1.22 instead ? |
Maybe Tempo should have it's own build image |
Let's just update to 0.33.2 if that works.
I honestly don't know how floating the patch works in a go.mod.
When/if we need to we can make our own. Otherwise we may as well share work with Loki. |
done |
Thanks for the fix! |
What this PR does:
Which issue(s) this PR fixes:
Fixes #3905
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]